avijayanhwx commented on a change in pull request #633: HDDS-3123. Create REST API to serve Pipeline information and integrate with UI in Recon URL: https://github.com/apache/hadoop-ozone/pull/633#discussion_r387957447
########## File path: hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestPipelineEndpoint.java ########## @@ -0,0 +1,236 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.api; + +import com.google.inject.AbstractModule; +import com.google.inject.Guice; +import com.google.inject.Injector; +import com.google.inject.Singleton; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos.DatanodeDetailsProto; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos.LifeCycleState; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos.PipelineID; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationType; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ContainerReplicaProto; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ContainerReportsProto; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.NodeReportProto; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.PipelineReport; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.PipelineReportsProto; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.SCMHeartbeatRequestProto; +import org.apache.hadoop.hdds.scm.container.ContainerInfo; +import org.apache.hadoop.hdds.scm.container.common.helpers.ContainerWithPipeline; +import org.apache.hadoop.hdds.scm.pipeline.Pipeline; +import org.apache.hadoop.hdds.scm.protocol.StorageContainerLocationProtocol; +import org.apache.hadoop.hdds.scm.server.OzoneStorageContainerManager; +import org.apache.hadoop.ozone.recon.GuiceInjectorUtilsForTestsImpl; +import org.apache.hadoop.ozone.recon.api.types.PipelineMetadata; +import org.apache.hadoop.ozone.recon.api.types.PipelinesResponse; +import org.apache.hadoop.ozone.recon.persistence.AbstractSqlDatabaseTest; +import org.apache.hadoop.ozone.recon.scm.ReconStorageContainerManagerFacade; +import org.apache.hadoop.ozone.recon.spi.StorageContainerServiceProvider; +import org.apache.hadoop.ozone.recon.spi.impl.StorageContainerServiceProviderImpl; +import org.apache.hadoop.test.LambdaTestUtils; +import org.hadoop.ozone.recon.schema.ReconTaskSchemaDefinition; +import org.hadoop.ozone.recon.schema.tables.daos.MissingContainersDao; +import org.hadoop.ozone.recon.schema.tables.daos.ReconTaskStatusDao; +import org.jooq.Configuration; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +import javax.ws.rs.core.Response; + +import static org.apache.hadoop.hdds.protocol.MockDatanodeDetails.randomDatanodeDetails; +import static org.apache.hadoop.hdds.recon.ReconConfigKeys.OZONE_RECON_DATANODE_ADDRESS_KEY; +import static org.apache.hadoop.ozone.recon.AbstractOMMetadataManagerTest.getRandomPipeline; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +/** + * Test for Pipeline Endpoint. + */ +public class TestPipelineEndpoint extends AbstractSqlDatabaseTest { + @Rule + public TemporaryFolder temporaryFolder = new TemporaryFolder(); + + private PipelineEndpoint pipelineEndpoint; + private ReconStorageContainerManagerFacade reconScm; + private boolean isSetupDone = false; + private String pipelineId; + private DatanodeDetails datanodeDetails; + private GuiceInjectorUtilsForTestsImpl guiceInjectorTest = + new GuiceInjectorUtilsForTestsImpl(); + private DatanodeDetailsProto datanodeDetailsProto; + private ContainerReportsProto containerReportsProto; + private long containerId = 1L; + private Pipeline pipeline; + private void initializeInjector() { + + Injector injector = Guice.createInjector(new AbstractModule() { + @Override + protected void configure() { + try { + datanodeDetails = randomDatanodeDetails(); + pipeline = getRandomPipeline(datanodeDetails); + pipelineId = pipeline.getId().getId().toString(); + + Configuration sqlConfiguration = + getInjector().getInstance((Configuration.class)); + + ContainerInfo containerInfo = new ContainerInfo.Builder() + .setContainerID(containerId) + .setReplicationFactor(ReplicationFactor.ONE) + .setState(LifeCycleState.OPEN) + .setOwner("test") + .setPipelineID(pipeline.getId()) + .setReplicationType(ReplicationType.RATIS) + .build(); + ContainerWithPipeline containerWithPipeline = + new ContainerWithPipeline(containerInfo, pipeline); + + ReconTaskSchemaDefinition taskSchemaDefinition = getInjector() + .getInstance(ReconTaskSchemaDefinition.class); + taskSchemaDefinition.initializeSchema(); + + ReconTaskStatusDao reconTaskStatusDao = + new ReconTaskStatusDao(sqlConfiguration); + MissingContainersDao missingContainersDao = + new MissingContainersDao(sqlConfiguration); + + bind(ReconTaskStatusDao.class).toInstance(reconTaskStatusDao); + bind(MissingContainersDao.class).toInstance(missingContainersDao); + + StorageContainerLocationProtocol mockScmClient = mock( + StorageContainerLocationProtocol.class); + StorageContainerServiceProvider mockScmServiceProvider = mock( + StorageContainerServiceProviderImpl.class); + when(mockScmServiceProvider.getPipeline( + pipeline.getId().getProtobuf())).thenReturn(pipeline); + when(mockScmServiceProvider.getContainerWithPipeline(containerId)) + .thenReturn(containerWithPipeline); + + OzoneConfiguration testOzoneConfiguration = + guiceInjectorTest.getTestOzoneConfiguration(temporaryFolder); + testOzoneConfiguration.set(OZONE_RECON_DATANODE_ADDRESS_KEY, + "0.0.0.0:0"); + bind(OzoneConfiguration.class).toInstance(testOzoneConfiguration); + bind(StorageContainerLocationProtocol.class) + .toInstance(mockScmClient); + bind(StorageContainerServiceProvider.class) + .toInstance(mockScmServiceProvider); Review comment: Seems like a lot of duplicated code between the 2 endpoint Test classes. Can we move this Test into the other class? We don't necessarily need a unit test for every endpoint class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
