adoroszlai commented on a change in pull request #649: HDDS-3120. Freon work
with OM HA.
URL: https://github.com/apache/hadoop-ozone/pull/649#discussion_r389912874
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyGenerator.java
##########
@@ -86,22 +91,24 @@ public Void call() throws Exception {
OzoneConfiguration ozoneConfiguration = createOzoneConfiguration();
- ensureVolumeAndBucketExist(ozoneConfiguration, volumeName, bucketName);
contentGenerator = new ContentGenerator(keySize, bufferSize);
metadata = new HashMap<>();
- try (OzoneClient rpcClient = OzoneClientFactory
- .getRpcClient(ozoneConfiguration)) {
-
- bucket =
- rpcClient.getObjectStore().getVolume(volumeName)
- .getBucket(bucketName);
+ OzoneClient rpcClient = null;
+ try {
+ rpcClient = createOzoneClient(omServiceID, ozoneConfiguration);
Review comment:
What's the reason for changing to `try-finally` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
