[
https://issues.apache.org/jira/browse/HDDS-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058979#comment-17058979
]
Mukul Kumar Singh commented on HDDS-3148:
-----------------------------------------
The log lines can still be seen in unit tests, do we also need a fix in Ratis ?
{code}
2020-03-13 23:39:41,241 [grpc-default-executor-6] WARN impl.RaftServerProxy
(RaftServerProxy.java:lambda$groupAddAsync$11(390)) -
61a7ef24-cbea-4b88-9144-bad6548684bd: Failed groupAdd*
GroupManagementRequest:client-E205209BDD04->61a7ef24-cbea-4b88-9144-bad6548684bd@group-A7E23A6BB079,
cid=4, seq=0, RW, null,
Add:group-A7E23A6BB079:[b65b6f18-ecf3-42b4-b408-9e75c3a179ec:127.0.0.1:51841,
9feb551e-5215-4db7-95aa-b9e23dad8ea7:127.0.0.1:51850,
61a7ef24-cbea-4b88-9144-bad6548684bd:127.0.0.1:51840]
java.util.concurrent.CompletionException:
org.apache.ratis.protocol.AlreadyExistsException:
61a7ef24-cbea-4b88-9144-bad6548684bd: Failed to add
group-A7E23A6BB079:[b65b6f18-ecf3-42b4-b408-9e75c3a179ec:127.0.0.1:51841,
9feb551e-5215-4db7-95aa-b9e23dad8ea7:127.0.0.1:51850,
61a7ef24-cbea-4b88-9144-bad6548684bd:127.0.0.1:51840] since the group already
exists in the map.
at
java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:292)
at
java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:308)
at
java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:593)
at
java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:577)
at
java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:617)
at
java.util.concurrent.CompletableFuture.thenApplyAsync(CompletableFuture.java:1993)
at
org.apache.ratis.server.impl.RaftServerProxy.groupAddAsync(RaftServerProxy.java:379)
at
org.apache.ratis.server.impl.RaftServerProxy.groupManagementAsync(RaftServerProxy.java:363)
at
org.apache.ratis.grpc.server.GrpcAdminProtocolService.lambda$groupManagement$0(GrpcAdminProtocolService.java:42)
at org.apache.ratis.grpc.GrpcUtil.asyncCall(GrpcUtil.java:160)
at
org.apache.ratis.grpc.server.GrpcAdminProtocolService.groupManagement(GrpcAdminProtocolService.java:42)
at
org.apache.ratis.proto.grpc.AdminProtocolServiceGrpc$MethodHandlers.invoke(AdminProtocolServiceGrpc.java:358)
at
org.apache.ratis.thirdparty.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:172)
at
org.apache.ratis.thirdparty.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:331)
at
org.apache.ratis.thirdparty.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:814)
at
org.apache.ratis.thirdparty.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
at
org.apache.ratis.thirdparty.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.ratis.protocol.AlreadyExistsException:
61a7ef24-cbea-4b88-9144-bad6548684bd: Failed to add
group-A7E23A6BB079:[b65b6f18-ecf3-42b4-b408-9e75c3a179ec:127.0.0.1:51841,
9feb551e-5215-4db7-95aa-b9e23dad8ea7:127.0.0.1:51850,
61a7ef24-cbea-4b88-9144-bad6548684bd:127.0.0.1:51840] since the group already
exists in the map.
at
org.apache.ratis.server.impl.RaftServerProxy$ImplMap.addNew(RaftServerProxy.java:83)
at
org.apache.ratis.server.impl.RaftServerProxy.groupAddAsync(RaftServerProxy.java:378)
... 13 more
{code}
> Logs cluttered by AlreadyExistsException from Ratis
> ---------------------------------------------------
>
> Key: HDDS-3148
> URL: https://issues.apache.org/jira/browse/HDDS-3148
> Project: Hadoop Distributed Data Store
> Issue Type: Wish
> Components: Ozone Datanode
> Reporter: Attila Doroszlai
> Assignee: Siddharth Wagle
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Ozone startup logs are cluttered by printing stack trace of
> AlreadyExistsException related to group addition. Example:
> {code}
> 2020-03-09 13:53:01,563 [grpc-default-executor-0] WARN impl.RaftServerProxy
> (RaftServerProxy.java:lambda$groupAddAsync$11(390)) -
> 7a07f161-9144-44b2-8baa-73f0e9299675: Failed groupAdd*
> GroupManagementRequest:client-27FB1A91809E->7a07f161-9144-44b2-8baa-73f0e9299675@group-E151028E3AC0,
> cid=2, seq=0, RW, null,
> Add:group-E151028E3AC0:[18f4e257-bf09-482e-b1bb-a2408a093ff7:172.17.0.2:43845,
> 7a07f161-9144-44b2-8baa-73f0e9299675:172.17.0.2:41551,
> 8a66c80e-ab55-4975-92a9-8aaf06ab418a:172.17.0.2:36921]
> java.util.concurrent.CompletionException:
> org.apache.ratis.protocol.AlreadyExistsException:
> 7a07f161-9144-44b2-8baa-73f0e9299675: Failed to add
> group-E151028E3AC0:[18f4e257-bf09-482e-b1bb-a2408a093ff7:172.17.0.2:43845,
> 7a07f161-9144-44b2-8baa-73f0e9299675:172.17.0.2:41551,
> 8a66c80e-ab55-4975-92a9-8aaf06ab418a:172.17.0.2:36921] since the group
> already exists in the map.
> at
> java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:292)
> at
> java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:308)
> at
> java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:607)
> at
> java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:591)
> at
> java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:631)
> at
> java.util.concurrent.CompletableFuture.thenApplyAsync(CompletableFuture.java:2006)
> at
> org.apache.ratis.server.impl.RaftServerProxy.groupAddAsync(RaftServerProxy.java:379)
> at
> org.apache.ratis.server.impl.RaftServerProxy.groupManagementAsync(RaftServerProxy.java:363)
> at
> org.apache.ratis.grpc.server.GrpcAdminProtocolService.lambda$groupManagement$0(GrpcAdminProtocolService.java:42)
> at org.apache.ratis.grpc.GrpcUtil.asyncCall(GrpcUtil.java:160)
> at
> org.apache.ratis.grpc.server.GrpcAdminProtocolService.groupManagement(GrpcAdminProtocolService.java:42)
> at
> org.apache.ratis.proto.grpc.AdminProtocolServiceGrpc$MethodHandlers.invoke(AdminProtocolServiceGrpc.java:358)
> at
> org.apache.ratis.thirdparty.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:172)
> at
> org.apache.ratis.thirdparty.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:331)
> at
> org.apache.ratis.thirdparty.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:814)
> at
> org.apache.ratis.thirdparty.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
> at
> org.apache.ratis.thirdparty.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.ratis.protocol.AlreadyExistsException:
> 7a07f161-9144-44b2-8baa-73f0e9299675: Failed to add
> group-E151028E3AC0:[18f4e257-bf09-482e-b1bb-a2408a093ff7:172.17.0.2:43845,
> 7a07f161-9144-44b2-8baa-73f0e9299675:172.17.0.2:41551,
> 8a66c80e-ab55-4975-92a9-8aaf06ab418a:172.17.0.2:36921] since the group
> already exists in the map.
> at
> org.apache.ratis.server.impl.RaftServerProxy$ImplMap.addNew(RaftServerProxy.java:83)
> at
> org.apache.ratis.server.impl.RaftServerProxy.groupAddAsync(RaftServerProxy.java:378)
> ... 13 more
> {code}
> Since these are "normal", I think stack trace should be suppressed.
> CC [~nanda]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
