smengcl edited a comment on issue #696: HDDS-3056. Allow all users to list all volumes URL: https://github.com/apache/hadoop-ozone/pull/696#issuecomment-601467093 > Thanks @smengcl for working on this. > The code change looks good. > > I do not have details about the conversation with Arpit/Sanjay you mentioned thus I am not merging this PR yet. As far as security is concerned, listing all volumes is a functionality suited for system admins. If I am not supposed to have access to read the contents of some volumes what benefit will I achieve by being able to list those volumes? Thus I am not able to understand what value this change brings to ozone or the user experience. Thanks for the comment Dinesh. You concern is totally valid. One motivation/background of this change is that in `ofs://`, all users should be able to list "root", which is essentially a `listVolumesByUser()` client call at this moment that returns only the list of volumes current user creates. So there is also a `tmp` mount (HDDS-2929) implemented for `ofs://`, the current implementation of which is asking an admin to create a volume named `tmp` (with world `ALL` ACL) during cluster setup, so every other user who are accessing mount point `ofs://om/tmp/` will be transparently directed to accessing bucket `md5(current_username)` in volume `tmp`. Now there is a visual glitch when listing. Since the volume `tmp` is created by an admin, if another user tries `ozone fs -ls ofs://om/`, he won't see volume/mount `tmp` at all. -- I admit a better way to fix this might be to hack listing results and inject mount `tmp`. The point is this is one example of the motivation. Yes there is this security implication behind this. I discussed with @xiaoyuyao a bit about this today. We plan to discuss with @arp7 about this tomorrow and see if we actually want to loosen the admin check of `listAllVolumes()`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
