timmylicheng commented on a change in pull request #678: HDDS-3179 Pipeline placement based on Topology does not have fallback URL: https://github.com/apache/hadoop-ozone/pull/678#discussion_r398622023
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java ########## @@ -403,7 +408,7 @@ private boolean checkAllNodesAreEqual(NetworkTopology topology) { @VisibleForTesting protected DatanodeDetails chooseNodeFromNetworkTopology( NetworkTopology networkTopology, DatanodeDetails anchor, - List<DatanodeDetails> excludedNodes) { + List<DatanodeDetails> excludedNodes) throws SCMException { Review comment: Updated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org