hanishakoneru commented on a change in pull request #625: HDDS-2980. Delete
replayed entry from OpenKeyTable during commit
URL: https://github.com/apache/hadoop-ozone/pull/625#discussion_r399554295
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCommitPartRequest.java
##########
@@ -147,11 +146,6 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
throw new OMException("Failed to commit Multipart Upload key, as " +
openKey + "entry is not found in the openKey table",
KEY_NOT_FOUND);
- } else {
- // Check the OpenKeyTable if this transaction is a replay of ratis
logs.
Review comment:
This check was redundant. Irrespective of whether KeyCreate Request was
replayed or not, if key+clientID exits in the openKey table, then the
CommitPart request should also be executed (same as we do for KeyCommit
Request).
If the same Key part was created again, the clientID would be different.
Hence the openKey would also be different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
