smengcl commented on issue #750: HDDS-3309. Add timeout to all integration tests
URL: https://github.com/apache/hadoop-ozone/pull/750#issuecomment-610051463
 
 
   > @smengcl `it-freon` is currently disabled globally, so any change to those 
tests is not being validated, ie. whether they work OK with the new timeouts or 
not. I think we should avoid changing them, to avoid unexpected failures later 
when enabling them.
   > 
   > `forkedProcessTimeoutInSeconds` applies to each test class. Test output is 
available in the artifact (eg. it-client.zip), although test results are not.
   > 
   > I think it would be more useful to change tests that time out with the 
current limit to use `GenericTestUtils.waitFor`, which prints a thread dump in 
case of timeout.
   
   Hmm I see `it-freon` is running in master branch? e.g. 
https://github.com/apache/hadoop-ozone/runs/564223039
   
   I can remove the modifications to the ignored freon tests. i.e. 
`TestOzoneClientKeyGenerator` and `TestRandomKeyGenerator`.
   
   I agree `GenericTestUtils.waitFor` is useful, but on a lower level. For 
example when we pinpointed the timeout to exact lines like the last assertion 
in `TestRandomKeyGenerator.bigFileThan2GB`. The goal of this jira however is 
just to add a class-global timeout. This should achieve the goal of collecting 
logs and displaying more friendly output.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to