esahekmat commented on issue #726: HDDS-3267. replace ContainerCache in BlockUtils by LoadingCache URL: https://github.com/apache/hadoop-ozone/pull/726#issuecomment-610978864 @elek Thank you for your review. you understand this PR very well. about the potential problem of evicting a reference while it is in use you're completely right, however we can address it by using weakValue eviction strategy which evict a value from the cache if there is no other (strong or soft) references to the value(ReferenceDB here). I will edit this PR to use weakValue eviction instead of size-based eviction. About the pain of using guava, you're right however, Ozone uses guava already. I think the ultimate solution to this is to shade it like the way Hadoop is trying to address it although I don't know the difficulties of this approach(shading).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
