avijayanhwx commented on issue #761: HDDS-3336. Metrics for Recon OzoneManager DB sync. URL: https://github.com/apache/hadoop-ozone/pull/761#issuecomment-611080801 > > Thank you for the information Marton! I am wondering if I should still keep the counter and time to keep it specific per recon client instance. In the future, more clients may use the same request with different input arguments, and the metrics will be averaged out across all clients. > > I am not sure if it will ever happen related to the OM db download RPC, but how knows.... > > But if you need a client side metrics: what about adding a `ProtocolMessageMetrics` to the `OzoneManagerProtocolClientSideTranslatorPB` (with some client specific tag, if needed). In that case you can have well-defined, unified metrics for all the OM calls on the recon side (without increasing the complexity anywhere else in the Recon code). @elek I think that is a good idea. I have removed the generic counter and timer metric for the RPC call, and I will do the client specific protocol message metrics in a future JIRA (since there is no other client who is going to use the getDBUpdates API in the near future).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
