cxorm commented on a change in pull request #399: HDDS-2424. Add the
recover-trash command server side handling.
URL: https://github.com/apache/hadoop-ozone/pull/399#discussion_r407256059
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java
##########
@@ -549,10 +549,12 @@ DBUpdates getDBUpdates(
* @param bucketName - The bucket name.
* @param keyName - The key user want to recover.
* @param destinationBucket - The bucket user want to recover to.
- * @return The recoverTrash
+ * @return The result of recovering operation is success or not.
* @throws IOException
*/
- boolean recoverTrash(String volumeName, String bucketName, String keyName,
- String destinationBucket) throws IOException;
+ default boolean recoverTrash(String volumeName, String bucketName,
+ String keyName, String destinationBucket) throws IOException {
+ return false;
+ }
Review comment:
@bharatviswa504
What do you think about this `cleanup write-request` ?
Could we set the write-operation with a `default` or
we need a separated interface addressed the `write-operation` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
