bharatviswa504 commented on a change in pull request #821: HDDS-3374. Addendum:
OMVolumeSetOwnerRequest doesn't check if user is already the owner
URL: https://github.com/apache/hadoop-ozone/pull/821#discussion_r408536061
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
##########
@@ -241,6 +242,19 @@ public void testOMClientProxyProvider() {
ozoneManager.getOmRpcServerAddr()));
}
+ @Test
+ public void testVolumeSetOwner() throws IOException {
+ String volumeName = UUID.randomUUID().toString();
+ store.createVolume(volumeName);
+
+ String ownerName = "someRandomUser1";
+
+ ClientProtocol proxy = store.getClientProxy();
+ proxy.setVolumeOwner(volumeName, ownerName);
+ // Set owner again. Expect no NPEs nor timeouts
Review comment:
Minor NIT: We don't need this comment, as this PR fixes the bug in the code
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
