timmylicheng commented on a change in pull request #668: HDDS-3139. Pipeline
placement should max out pipeline usage
URL: https://github.com/apache/hadoop-ozone/pull/668#discussion_r408633470
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java
##########
@@ -110,17 +97,11 @@ boolean meetCriteria(DatanodeDetails datanodeDetails, int
nodesRequired) {
pipelineNumDeductable++;
}
}
- boolean meet = (nodeManager.getPipelinesCount(datanodeDetails)
- - pipelineNumDeductable) < heavyNodeCriteria;
- if (!meet && LOG.isDebugEnabled()) {
- LOG.debug("Pipeline Placement: can't place more pipeline on heavy " +
- "datanodeļ¼ " + datanodeDetails.getUuid().toString() +
- " Heaviness: " + nodeManager.getPipelinesCount(datanodeDetails) +
- " limit: " + heavyNodeCriteria);
- }
- return meet;
+ return pipelines.size() - pipelineNumDeductable;
}
+
+
/**
* Filter out viable nodes based on
* 1. nodes that are healthy
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
