sodonnel commented on issue #745: HDDS-3315. Use EventQueue for delayed/immediate safe mode notifications URL: https://github.com/apache/hadoop-ozone/pull/745#issuecomment-613954771 This change LGTM. My only comment, which is nice to have, is that I wonder if we should move the logic in `SafeModeHandler.onMessage()` into `SCMSafeModeManager.emitSafeModeStatus()` - that would allow us to get rid of that class entirely and make the logic slightly easier to follow. However I am +1 on this how it is, so its up to you if you think it makes sense to make that further change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
