elek commented on a change in pull request #834:
URL: https://github.com/apache/hadoop-ozone/pull/834#discussion_r411456674
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/freon/OzoneGetConf.java
##########
@@ -234,7 +236,7 @@ public Integer run() throws Exception {
public int doWorkInternal(OzoneGetConf tool, String[] args)
throws IOException {
Collection<InetSocketAddress> addresses = HddsUtils
- .getSCMAddresses(tool.getConf());
+ .getSCMAddresses(new
LegacyHadoopConfigurationSource(tool.getConf()));
Review comment:
> Especially since we explicitly create OzoneGetConf with an
OzoneConfiguration
I think we create the `OzoneGetConf` with `Configuration` which includes an
`OzoneConfiguration`:
```java
Configuration conf = new Configuration();
conf.addResource(new OzoneConfiguration());
int res = ToolRunner.run(new OzoneGetConf(conf), args);
```
`conf` is a `Configuration` not an `OzoneConfiguration`.
But I changed it to use `OzoneConfiguration.of`
(BTW, would be great to switch to use GenericCli instead of `ToolRunner`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
