fapifta commented on pull request #881: URL: https://github.com/apache/hadoop-ozone/pull/881#issuecomment-622322082
Thinking it a bit further, the current implementation basically brings rack as a term into ReplicaManager just via integers and counts, so I was a bit harsh when stating that effectively we make ReplicationManager rack aware. However I still think this whole logic of handle(Over|Under)ReplicatedContainers has to be part of the placement policy, as that should be the only point that handles the placement of containers, and if we leave this logic in ReplicationManager, then it will explode further and will be way harder to maintain as soon as a new placement policy is added, moreover it makes it impossible to really plug in a new placement policy by just a config change, as it is planned now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
