sodonnel commented on a change in pull request #881:
URL: https://github.com/apache/hadoop-ozone/pull/881#discussion_r420141056
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
##########
@@ -393,8 +396,11 @@ private boolean isContainerHealthy(final ContainerInfo
container,
*/
private boolean isContainerUnderReplicated(final ContainerInfo container,
final Set<ContainerReplica> replicas) {
+ boolean misReplicated = !getPlacementStatus(
Review comment:
My thinking on this, is that the policy states the replica "must be on
AT LEAST two racks". I don't believe we should consider it over-replicated if
it turns out to be on 3 somehow. That logic is consistent with HDFS, and
probably provides better redundancy and locality (more racks is likely better
in almost all cases).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
