lokeshj1703 commented on a change in pull request #899:
URL: https://github.com/apache/hadoop-ozone/pull/899#discussion_r421335507
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestKeyInputStream.java
##########
@@ -257,7 +257,7 @@ public void testSeek() throws Exception {
// Seek operation should not result in any readChunk operation.
Assert.assertEquals(readChunkCount, metrics
- .getContainerOpsMetrics(ContainerProtos.Type.ReadChunk));
+ .getContainerOpCountMetrics(ContainerProtos.Type.ReadChunk));
Review comment:
I agree it should not be -1. But if we look at completedCount it doesn't
have a decrement method whereas pendingOpCount does have it. So completedCount
will never decrement from 0 but pendingOpCount can. There is a problem with how
we are decrementing the pending metric (we are decrementing when a reply comes
and in onError call) and that should be tracked via a separate jira. There
should be a better mechanism to decrement pendingOpCount.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
