smengcl commented on a change in pull request #876:
URL: https://github.com/apache/hadoop-ozone/pull/876#discussion_r422291764
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1690,14 +1690,10 @@ public boolean getAclsEnabled() {
}
/**
- * Changes the owner of a volume.
- *
- * @param volume - Name of the volume.
- * @param owner - Name of the owner.
- * @throws IOException
+ * {@inheritDoc}
*/
@Override
- public void setOwner(String volume, String owner) throws IOException {
+ public boolean setOwner(String volume, String owner) throws IOException {
Review comment:
> Just curious if this ever return false?
Yes. It returns false when the given user is already the owner of the
volume:
https://github.com/apache/hadoop-ozone/pull/876/commits/4613bd0724ee0be97651aaa7364f3921436b9183#diff-990a43aeb92fe45392bdab4484ec488bR150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
