cku328 edited a comment on pull request #909: URL: https://github.com/apache/hadoop-ozone/pull/909#issuecomment-627840824
Thanks @avijayanhwx for the review and comments. I have modified this test case mainly by referring to the actions of other similar test cases. I speculate that the report is only updated under specific conditions, it is not responded to through _NodeReportHandler_. This requires initializing a _NodeReportHandler_ to process and update the new custom strorage reports. A better approach, I think, should be to take nodeReport into the parameter when registering the node and first update it at that time, but in the `TestUtils:createRandomDatanodeAndRegister(...)` method _nodeReport_ is set to null by default. I have modified the commit, which should be better... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
