avijayanhwx commented on a change in pull request #919:
URL: https://github.com/apache/hadoop-ozone/pull/919#discussion_r424808593
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/NodeEndpoint.java
##########
@@ -81,31 +83,44 @@ public Response getDatanodes() {
String hostname = datanode.getHostName();
Set<PipelineID> pipelineIDs = nodeManager.getPipelines(datanode);
List<DatanodePipeline> pipelines = new ArrayList<>();
+ AtomicInteger leaderCount = new AtomicInteger();
Review comment:
Can be regular 'int' instead of 'AtomicInteger'.
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/NodeEndpoint.java
##########
@@ -81,31 +83,44 @@ public Response getDatanodes() {
String hostname = datanode.getHostName();
Set<PipelineID> pipelineIDs = nodeManager.getPipelines(datanode);
List<DatanodePipeline> pipelines = new ArrayList<>();
+ AtomicInteger leaderCount = new AtomicInteger();
+ DatanodeMetadata.Builder builder = DatanodeMetadata.newBuilder();
pipelineIDs.forEach(pipelineID -> {
try {
Pipeline pipeline = pipelineManager.getPipeline(pipelineID);
+ String leaderNode = pipeline.getLeaderNode().getHostName();
DatanodePipeline datanodePipeline = new DatanodePipeline(
pipelineID.getId(),
pipeline.getType().toString(),
- pipeline.getFactor().getNumber()
+ pipeline.getFactor().getNumber(),
+ leaderNode
);
pipelines.add(datanodePipeline);
+ if (leaderNode.equals(hostname)) {
Review comment:
UUID equality check is better here.
`pipeline.getLeaderId().equals(datanode.getUuid())`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
