[
https://issues.apache.org/jira/browse/HDDS-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107004#comment-17107004
]
Marton Elek commented on HDDS-3582:
-----------------------------------
Thanks to open this, I totally agree.
I think the import group management is very important to have less conflicts
(and easy to manage with IDE plugins).
I am also fine with increasing the line length. (Ratis uses 120 as far as I
remember). I think it increases the readability as we don't need to have so
many line breaks. (Additional notes: all of the current developer AND console
tools support soft line breaks, in case of somebody uses an old crt monitor, it
can be wrapped)
I would also remove the requirement of package-info.java. I don't know any of
them which are useful especially as we don't generate javadoc. I would move the
interfaces of the client API to a separated maven project and generate Javadoc
/ maintain package-info.java only there. But until that It can be optional
(IMHO)
> Update Checkstyle rule
> ----------------------
>
> Key: HDDS-3582
> URL: https://issues.apache.org/jira/browse/HDDS-3582
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.6.0
> Reporter: maobaolong
> Priority: Major
>
> Now. the rules of checkstyle is hadoop style, as we all know, hadoop repo
> started 10 years ago, so some of its rules need to be update.
> For example.
> - 100 length characters of a line make more sense, because most of all have a
> better monitor than 10 years ago.
> - We need more style rules, such as, behind and after "{" and "}" should have
> a space.
> - We should have manage the import into group and order them
> hope our community getting better and better
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
