sodonnel commented on a change in pull request #937:
URL: https://github.com/apache/hadoop-ozone/pull/937#discussion_r426717257
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java
##########
@@ -108,9 +108,11 @@ public long putBlock(Container container, BlockData data)
throws IOException {
// transaction is reapplied in the ContainerStateMachine on restart.
// It also implies that the given block must already exist in the db.
// just log and return
- LOG.warn("blockCommitSequenceId {} in the Container Db is greater than"
- + " the supplied value {}. Ignoring it",
- containerBCSId, bcsId);
+ if (LOG.isDebugEnabled()) {
Review comment:
Is it necessary to wrap a debug log entry in the `if
(LOG.isDebugEnabled())` statement? It is my understanding, that so long as you
are not doing string interpolation in the log message and are passing simple
variables as any parameters to the log message (ie not doing any computation to
calculate the values being passed), then LOG4J does the correct thing and there
is no performance penalty to removing the IF wrapper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
