[ 
https://issues.apache.org/jira/browse/HDDS-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110624#comment-17110624
 ] 

Wei-Chiu Chuang commented on HDDS-3589:
---------------------------------------

Yes please make it a PR.

Some quick comments:

What is the version of HBase tested? How was it tested? Does HBase store HFiles 
on Ozone, or does it write WAL on Ozone?

{code}
public void hflush() throws IOException {
            Thread.dumpStack();
{code}
The Thread.dumpStack() looks redundant. You want to remove it in production 
code.

The hasCapability() was added by HDFS-11644, Hadoop 2.9 and above. This would 
limit Ozone's Hadoop support.

> Support running HBase on Ozone.
> -------------------------------
>
>                 Key: HDDS-3589
>                 URL: https://issues.apache.org/jira/browse/HDDS-3589
>             Project: Hadoop Distributed Data Store
>          Issue Type: New Feature
>            Reporter: Sadanand Shenoy
>            Assignee: Sadanand Shenoy
>            Priority: Major
>         Attachments: Hflush_impl.patch
>
>
> The aim of this Jira is to support Hbase to run on top of Ozone. In order to 
> achieve this , the Syncable interface was implemented which contains the 
> hflush() API which basically commits an open key into OM.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to