elek edited a comment on pull request #930: URL: https://github.com/apache/hadoop-ozone/pull/930#issuecomment-630706299
Good point @bharatviswa504 https://junit.org/junit4/javadoc/latest/ > The Timeout Rule applies the same timeout to all test methods in a class: But the the pom.xml level 900 sec timeout (mentioned by Xiaoyu) is global for the class: ``` <surefire.fork.timeout>900</surefire.fork.timeout> ... <forkedProcessTimeoutInSeconds>${surefire.fork.timeout}</forkedProcessTimeoutInSeconds> ``` > `<forkedProcessTimeoutInSeconds>` Kill the forked test process after a certain number of seconds. If set to 0, wait forever for the process, never timing out. But this is not per-module, it's per fork, and we use one for per test class: ``` grep -r reuse --include=pom.xml hadoop-ozone/pom.xml: <reuseForks>false</reuseForks> hadoop-hdds/pom.xml: <reuseForks>false</reuseForks> pom.xml: <reuseForks>false</reuseForks> ``` > `<reuseForks>` Indicates if forked VMs can be reused. If set to "false", a new VM is forked for each test class to be executed. If set to "true", up to forkCount VMs will be forked and then reused to execute all tests. https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html So, it seems to be useful (and a better structure, anyway). I would merge it if no more objections. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
