elek commented on pull request #924: URL: https://github.com/apache/hadoop-ozone/pull/924#issuecomment-630714882
Thanks the answers @mukul1987 > backward compatibility should be on both the protos both for express as well as rolling upgrades. As far as I know there is no plan to support rolling upgrade, we don't need to force backward compatibility for RPC. >> What should we put to the lock file? Is the lock file from the last release should be added and upgrade with each release? Or the first/(last?) version from the previous major line? > The lock file should be committed along with the source code to identify backward incompatibility issues. I understand this part, The question was about the details. Which version is committed and when? During an offline discussion we agreed that we can keep the version from the previous release until the next incompatible change. In case of incompatible change (right now) we should update the lock file *and* explain in the PR why did we update it. By default we should keep the lock file untouched (IMHO). We can also make the process of updating the lock file during the release process more automatic. But these are just random thoughts. Let's merge this PR first, start to use it, and we can adjust (and document !!) our usage patterns based on the experiences... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
