[
https://issues.apache.org/jira/browse/HDDS-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Elek updated HDDS-3595:
------------------------------
Issue Type: Improvement (was: Bug)
> Add a maven proto file backward compatibility checker into Ozone.
> -----------------------------------------------------------------
>
> Key: HDDS-3595
> URL: https://issues.apache.org/jira/browse/HDDS-3595
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.6.0
>
>
> The plugin proto-backwards-compat-maven-plugin flags incompatible protobuf
> changes.
> cc [~arp] [~avijayan] [~elek]
> https://github.com/salesforce/proto-backwards-compat-maven-plugin
> and
> https://mvnrepository.com/artifact/com.salesforce.servicelibs/proto-backwards-compatibility
> To test, I modified the following code in proto
> {code}
> diff --git a/hadoop-ozone/csi/src/main/proto/csi.proto
> b/hadoop-ozone/csi/src/main/proto/csi.proto
> index 3bd53a075..b8a984de2 100644
> --- a/hadoop-ozone/csi/src/main/proto/csi.proto
> +++ b/hadoop-ozone/csi/src/main/proto/csi.proto
> @@ -119,7 +119,7 @@ message GetPluginInfoResponse {
> // characters or less, beginning and ending with an alphanumeric
> // character ([a-z0-9A-Z]) with dashes (-), dots (.), and
> // alphanumerics between. This field is REQUIRED.
> - string name = 1;
> + string newName = 1;
> {code}
> and this flagged the following change
> {code}
> [ERROR] CONFLICT: "GetPluginInfoResponse" field: "name" has been removed, but
> is not reserved [csi.proto]
> [ERROR] CONFLICT: "GetPluginInfoResponse" field: "newName" ID: 1 has an
> updated name, previously "name" [csi.proto]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
