captainzmc commented on a change in pull request #814:
URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r427247838
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyArgs.java
##########
@@ -70,6 +72,8 @@ private OmKeyArgs(String volumeName, String bucketName,
String keyName,
this.refreshPipeline = refreshPipeline;
this.acls = acls;
this.sortDatanodesInPipeline = sortDatanode;
+ this.keyNameList = keyNameList;
Review comment:
> Do we need `String keyName` argument ? Can you please incorporate
`String keyName` argument into the `keyNameList` argument, something similar
you have very well refactored for `keyNameList.add(keyName);` in deleteKey api.
The keyName in OmKeyArgs is Shared with other interfaces. Operations like
create and list still need to use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
