xiaoyuyao commented on a change in pull request #934:
URL: https://github.com/apache/hadoop-ozone/pull/934#discussion_r428217442
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ClosePipelineSubcommand.java
##########
@@ -38,14 +40,59 @@
@CommandLine.ParentCommand
private PipelineCommands parent;
- @CommandLine.Parameters(description = "ID of the pipeline to close")
+ @CommandLine.Parameters(description = "ID of the pipeline to close,"
+ + "'ALL' means all pipeline")
private String pipelineId;
+ @CommandLine.Option(names = {"-ffc", "--filterByFactor"},
Review comment:
Can you add some acceptance tests for this as you've done in the
description?
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ClosePipelineSubcommand.java
##########
@@ -38,14 +40,59 @@
@CommandLine.ParentCommand
private PipelineCommands parent;
- @CommandLine.Parameters(description = "ID of the pipeline to close")
+ @CommandLine.Parameters(description = "ID of the pipeline to close,"
+ + "'ALL' means all pipeline")
private String pipelineId;
+ @CommandLine.Option(names = {"-ffc", "--filterByFactor"},
Review comment:
Can you add some acceptance tests for this as you've done manually in
the description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
