elek commented on a change in pull request #900:
URL: https://github.com/apache/hadoop-ozone/pull/900#discussion_r428559109
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/protocol/ClientProtocol.java
##########
@@ -481,9 +484,6 @@ void cancelDelegationToken(Token<OzoneTokenIdentifier>
token)
*/
S3SecretValue getS3Secret(String kerberosID) throws IOException;
- @VisibleForTesting
Review comment:
End users shouldn't use any public method which are annotated with
`@VisibleForTesting` or `@Private`. And they should be careful if `@Stable` is
missing from the class or methods. So I think it's not a problem here.
But I agree. And this is the reason why I think this method (independent
from the patch) should be added only for the implementation not for the
interface. If it's `VisibleForTesting`, we can do an easy cast during the unit
test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
