ChenSammi commented on a change in pull request #814:
URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r429091904



##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -830,7 +832,7 @@ message LookupKeyResponse {
 
 message RenameKeyRequest{
     required KeyArgs keyArgs = 1;

Review comment:
       Agree. Use list of KeyArgs instead of add a new keyNameList field. 

##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -830,7 +832,7 @@ message LookupKeyResponse {
 
 message RenameKeyRequest{
     required KeyArgs keyArgs = 1;

Review comment:
       Agree. Use list of KeyArgs instead of add a new keyNameList field. 

##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -830,7 +832,7 @@ message LookupKeyResponse {
 
 message RenameKeyRequest{
     required KeyArgs keyArgs = 1;

Review comment:
       Agree. Use list of KeyArgs instead of add a new keyNameList field. 

##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -830,7 +832,7 @@ message LookupKeyResponse {
 
 message RenameKeyRequest{
     required KeyArgs keyArgs = 1;

Review comment:
       Agree. Use list of KeyArgs instead of add a new keyNameList field. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to