dineshchitlangia commented on a change in pull request #972:
URL: https://github.com/apache/hadoop-ozone/pull/972#discussion_r430840967
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
##########
@@ -66,9 +66,14 @@ public Void call() throws Exception {
// Print pipeline of an existing container.
String machinesStr = container.getPipeline().getNodes().stream().map(
- DatanodeDetails::getHostName).collect(Collectors.joining(","));
+ InfoSubcommand::buildDatanodeDisplay)
+ .collect(Collectors.joining(",\n"));
LOG.info("Datanodes: [{}]", machinesStr);
return null;
}
}
+
+ private static String buildDatanodeDisplay(DatanodeDetails details) {
Review comment:
Trivial NIT:
```suggestion
private static String buildDatanodeDetails(DatanodeDetails details) {
```
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
##########
@@ -66,9 +66,14 @@ public Void call() throws Exception {
// Print pipeline of an existing container.
String machinesStr = container.getPipeline().getNodes().stream().map(
- DatanodeDetails::getHostName).collect(Collectors.joining(","));
+ InfoSubcommand::buildDatanodeDisplay)
Review comment:
```suggestion
InfoSubcommand::buildDatanodeDetails)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
