vivekratnavel commented on a change in pull request #971:
URL: https://github.com/apache/hadoop-ozone/pull/971#discussion_r431359827
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerDataScanner.java
##########
@@ -66,7 +67,7 @@ public ContainerDataScanner(ContainerScrubberConfiguration
conf,
throttler = new HddsDataTransferThrottler(conf.getBandwidthPerVolume());
canceler = new Canceler();
metrics = ContainerDataScrubberMetrics.create(volume.toString());
- setName("ContainerDataScanner(" + volume + ")");
+ setName(NAME + volume + ")");
Review comment:
```suggestion
setName(String.format(NAME_FORMAT, volume));
```
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerDataScanner.java
##########
@@ -49,6 +49,7 @@
private final Canceler canceler;
private final ContainerDataScrubberMetrics metrics;
private final long dataScanInterval;
+ private static final String NAME = "ContainerDataScanner(";
Review comment:
Can we use String format here?
```suggestion
private static final String NAME_FORMAT = "ContainerDataScanner(%s)";
```
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerDataScanner.java
##########
@@ -162,13 +165,14 @@ private static void logScanCompleted(
public synchronized void shutdown() {
this.stopping = true;
- this.canceler.cancel("ContainerDataScanner("+volume+") is shutting down");
+ this.canceler.cancel(NAME + volume + ") is shutting down");
Review comment:
```suggestion
this.canceler.cancel(String.format(NAME_FORMAT, volume) + " is shutting
down");
```
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerDataScanner.java
##########
@@ -179,8 +183,7 @@ public ContainerDataScrubberMetrics getMetrics() {
@Override
public String toString() {
- return "ContainerDataScanner(" + volume +
- ", " + volume.getStorageID() + ")";
+ return NAME + volume + ", " + volume.getStorageID() + ")";
Review comment:
```suggestion
return String.format(NAME_FORMAT, volume + ", " + volume.getStorageID());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
