rakeshadr commented on pull request #895: URL: https://github.com/apache/hadoop-ozone/pull/895#issuecomment-635135367
Thanks a lot @elek for the comments with detailed explanation. > 1. I guess you would like to test the correctness and not interested about the performance. But I love the numbers and I think it's always good to have. Sure, I will add the timer and helpful during perf evaluation. > 1. There is a `prefix` field in the `BaseFreonGenerator`. This is a random string, which can be specified. > (One easy way to use it to generate dirs in `rpath` + `/` + `prefix`) This tool provides '--nameLen' option to the users to define the length of the random name of the directory. Another point is, `/` + `prefix` will add additional depth(sub-dir), which HadoopDirTreeGenerator#makeDirWithGivenNumberOfFiles() is already doing it. I am not finding any usage of 'prefix' in this tool and skip this comment. Does that make sense to you? Thanks! > 1. We have a `ContentGenerator` class which can do the the random key generation. I think it can be used here... If you see some limitation of it, we can improve it as well... Yes, will use ContentGenerator for writing the content. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
