Simon0806 edited a comment on pull request #989: URL: https://github.com/apache/hadoop-ozone/pull/989#issuecomment-636476216
Hi elek, thanks for your reply, Actually I think this is not a high priority fix because we can still put the necessary configurations in ozone-site.xml, I can test your patch in my cases to see if it works well. on the other hand, I have another question, currently we use java annotation to generate the default configuration, so for some cases it will load the default value, I think it's a little complex because it depends on the maven compile. my suggestion is to make a unify configuration class and put default value on it, this way we don't need to generate configuration value during compile, just like what HiveConf.java in hive project does , what do you think ? @elek ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
