GlenGeng commented on a change in pull request #1041:
URL: https://github.com/apache/hadoop-ozone/pull/1041#discussion_r437116560



##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -346,6 +346,9 @@ message VolumeInfo {
     optional uint64 creationTime = 7;
     optional uint64 objectID = 8;
     optional uint64 updateID = 9;
+    optional uint64 quotaUsageInBytes = 10;
+    optional uint64 quotaInCounts = 11;
+    optional uint64 quotaUsageInCounts = 12;

Review comment:
       Will it be better if we can enhance `OzoneQuota` to let it not only 
handle quota in bytes but also quota in counts, such that encapsulate code in 
`TraditionalBinaryPrefix`?
   
   It would be cleaner by adding a OzoneQuotaProto to encapsulate 
quotaUsageInBytes,  quotaUsageInCounts, quotaUsageInCount, quotaInCount, and 
reuse it.
   
   BTW, `namespaceQuota`, `storagespaceQuota`, `ssQuota`, `nsQuota`, maybe we 
need unify the naming.

##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -346,6 +346,9 @@ message VolumeInfo {
     optional uint64 creationTime = 7;
     optional uint64 objectID = 8;
     optional uint64 updateID = 9;
+    optional uint64 quotaUsageInBytes = 10;
+    optional uint64 quotaInCounts = 11;
+    optional uint64 quotaUsageInCounts = 12;

Review comment:
       Will it be better if we can enhance `OzoneQuota` to let it not only 
handle quota in bytes but also quota in counts, such that encapsulate code in 
`TraditionalBinaryPrefix`?
   
   It would be cleaner by adding a `OzoneQuotaProto` to encapsulate 
`quotaUsageInBytes`,  `quotaUsageInCounts`, `quotaUsageInCount`, 
`quotaInCount`, and reuse it.
   
   BTW, `namespaceQuota`, `storagespaceQuota`, `ssQuota`, `nsQuota`, maybe we 
need unify the naming.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to