Simon0806 commented on a change in pull request #1041:
URL: https://github.com/apache/hadoop-ozone/pull/1041#discussion_r437142895



##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -346,6 +346,9 @@ message VolumeInfo {
     optional uint64 creationTime = 7;
     optional uint64 objectID = 8;
     optional uint64 updateID = 9;
+    optional uint64 quotaUsageInBytes = 10;
+    optional uint64 quotaInCounts = 11;
+    optional uint64 quotaUsageInCounts = 12;

Review comment:
       That's a good point, I will see the effect to modify.

##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -346,6 +346,9 @@ message VolumeInfo {
     optional uint64 creationTime = 7;
     optional uint64 objectID = 8;
     optional uint64 updateID = 9;
+    optional uint64 quotaUsageInBytes = 10;
+    optional uint64 quotaInCounts = 11;
+    optional uint64 quotaUsageInCounts = 12;

Review comment:
       That's a good point, I will see the workload to modify.

##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -346,6 +346,9 @@ message VolumeInfo {
     optional uint64 creationTime = 7;
     optional uint64 objectID = 8;
     optional uint64 updateID = 9;
+    optional uint64 quotaUsageInBytes = 10;
+    optional uint64 quotaInCounts = 11;
+    optional uint64 quotaUsageInCounts = 12;

Review comment:
       That's a good point, but here I just want to extend it, if I add a 
OzoneQuotaProto to encapsulate all the quota related fields, the quotaInBytes 
will be useless in original pb format.
   I will check if there are some places can be unify the variable name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to