vivekratnavel commented on pull request #1032: URL: https://github.com/apache/hadoop-ozone/pull/1032#issuecomment-641512745
Thanks for the review @avijayanhwx > 1. The only way to close the volume and bucket drop down is to click on the 'V' icon in the drop down box. IMO, the intuitive way would be to have the dropdown close if we click outside. Is this a plotly library limitation? I also experienced the same bug and upon researching a bit, it seems like a temporary bug in react-select for multi-select dropdowns. https://github.com/JedWatson/react-select/issues/3756 I will keep an eye on the open issue against react-select and fix it in Recon once that issue gets resolved. Unfortunately, react-select is one of the most popular select dropdown components for React and there are no other alternatives that offer the features of react-select. > 2. Is it possible to have a refresh icon that refreshes the histogram with the current volume and bucket selections maintained? Is there a way to do this already? We can maintain the volume and bucket selection in browser's local storage, but the problem there will be to handle any changes to selected volume or bucket. For example, if the selected volume or bucket gets deleted, then it needs to be handled. And, for this use case alone, we will have to build a component to persist data to local storage. I prefer not to persist the selection information at-least at this point. We can consider adding persistence to local storage in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
