GlenGeng commented on a change in pull request #1041:
URL: https://github.com/apache/hadoop-ozone/pull/1041#discussion_r437846415



##########
File path: 
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/VolumeArgs.java
##########
@@ -107,7 +118,8 @@ public String getQuota() {
   public static class Builder {
     private String adminName;
     private String ownerName;
-    private String volumeQuota;
+    private String volumeSsQuota;
+    private long volumeNsQuota;

Review comment:
       `volumeSsQuota` and `volumeNsQuota`
   ditto, consider a better naming, it will be easier to for others to use and 
maintain.

##########
File path: 
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/OzoneQuota.java
##########
@@ -25,26 +25,73 @@
  * represents an OzoneQuota Object that can be applied to
  * a storage volume.
  */
-public class OzoneQuota {
+public final class OzoneQuota {
 
   public static final String OZONE_QUOTA_BYTES = "BYTES";
+  public static final String OZONE_QUOTA_KB = "KB";
   public static final String OZONE_QUOTA_MB = "MB";
   public static final String OZONE_QUOTA_GB = "GB";
   public static final String OZONE_QUOTA_TB = "TB";
 
-  private Units unit;
-  private long size;
-
   /** Quota Units.*/
   public enum Units {UNDEFINED, BYTES, KB, MB, GB, TB}
 
+  private long namespaceQuota;

Review comment:
       add comments to explain the meaning of namespaceQuota and 
storagespaceQuota.

##########
File path: hadoop-hdds/docs/content/shell/VolumeCommands.md
##########
@@ -42,7 +42,7 @@ assign it to a user.
 |  Uri                           | The name of the volume.                     
                   |
 
 {{< highlight bash >}}
-ozone sh volume create --quota=1TB --user=bilbo /hive
+ozone sh volume create -ssq=1TB --user=bilbo /hive

Review comment:
       `-ssq `is hard to understand, thus hard to use. Can we give it a self 
explain name ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to