elek commented on pull request #1031: URL: https://github.com/apache/hadoop-ozone/pull/1031#issuecomment-642010606
Thanks the patch @runzhiwang It looks correct me, but it's also a question about the long-term usage of `getServiceInfo`. Originally it was introduced (as far as I remember) to get the address of the SCM. But over the time the client is improved to avoid all the direct calls to the SCM. I agree, that long-term we should use proxy users for S3 and pooling the connections. Short-term this patch looks good to me, but why don't we use the `getServiceInfo` in case of secure clusters? Do we need to replace it with something simple. I would be interested about the opinion of @nandakumar131. As far as I remember he worked on the original implementation. Personally I think a generic `getServiceClient` can be useful. For example active `storage-class`-es can be downloaded from the server at the beginning of the connection. But that's a long term plan and this patch can help short term. Let's wait for more opinions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
