smengcl edited a comment on pull request #1046: URL: https://github.com/apache/hadoop-ozone/pull/1046#issuecomment-642120503
> Thanks this patch @smengcl (And sorry for the master changes, we worked paralell.) > > Understanding this PR is really challenging. Finally, I fetched the PR branch and compared with the master and everything seems to be the right place. Thanks for the review @elek . Actually I put a [compare link](https://github.com/smengcl/hadoop-ozone/compare/HDDS-2665-ofs...HDDS-3767) in a previous comment which should have make the review easier in theory. > > One question: Why did you deleted `TestRootedOzoneFileSystemWithMocks.java`? I removed `TestRootedOzoneFileSystemWithMocks.java` because HDDS-3627 removed `TestOzoneFileSystemWithMocks.java`. I have just restored `TestRootedOzoneFileSystemWithMocks.java` under `ozonefs`. > > And one comment: `META-INF/services/...FileSystem` entries can be created for ofs, too. (In the future) I believe we could only put one implementation [here](https://github.com/apache/hadoop-ozone/blob/072370b947416d89fae11d00a84a1d9a6b31beaa/hadoop-ozone/ozonefs/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem#L16)? Maybe later we can replace `org.apache.hadoop.fs.ozone.OzoneFileSystem` with `org.apache.hadoop.fs.ozone.RootedOzoneFileSystem`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
