xiaoyuyao commented on a change in pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054#discussion_r438998025
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java
##########
@@ -53,15 +54,15 @@ private OzoneAclUtil(){
* @return list of OzoneAcls
* */
public static List<OzoneAcl> getAclList(String userName,
- List<String> userGroups, ACLType userRights, ACLType groupRights) {
+ String[] userGroups, ACLType userRights, ACLType groupRights) {
Review comment:
Is there a particular reason to change from getGroups to
getGroupNames(), the later involves list->array->list conversion which can be
expensive when large number of groups exist for the user.
##########
File path:
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/exception/S3ErrorTable.java
##########
@@ -29,6 +31,9 @@
*/
public final class S3ErrorTable {
+ private final static Logger LOG = LoggerFactory.getLogger(
+ S3ErrorTable.class);
Review comment:
This seems to be the main part matching scope of the title. Should we
use separate tickets to track other changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
