sodonnel commented on pull request #921: URL: https://github.com/apache/hadoop-ozone/pull/921#issuecomment-643494970
> There are still lots of contributor around me complain with the 80 character per line limitation. > So a month past, a vehemently discussion has taken place in the mail-list, i think everyone have many arguments, but everyone try to persuade other, but nobody can persuade other. This is the problem with a change like this. Its a debate where there is no "correct" answer. Some like it one way and some like it another. However that is not a reason to not change - as you said, software is always changing and in my opinion the style can change too. We can see that as the Java language has evolved over the versions, software gets refactored etc. > It seems we have no better idea than vote, and everyone is equal, i don't think it's a good idea of giving more weight of people who did special contribution for Ozone. I believe a vote is the best way to get an idea of what the community wants. Let the people who are actively involved in the project give their opinion. Its probably best to do this like a normal release or merge vote. Post it to the mailing list, and Slack and give it 7 days for responses. I'd be inclined to with just two options 80 or 120, but add in the 100 option too if you like. I'd be happy with 100 or 120. Perhaps going for the middle ground (100) would be more sympathetic to the existing code style as the lines would not be too much longer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
