maobaolong commented on a change in pull request #1033:
URL: https://github.com/apache/hadoop-ozone/pull/1033#discussion_r439781866
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
##########
@@ -265,7 +265,9 @@ private void initializeStateMachine() {
stateMachine.addTransition(
NodeState.DECOMMISSIONING, NodeState.DECOMMISSIONED,
NodeLifeCycleEvent.DECOMMISSIONED);
-
+ stateMachine.addTransition(
Review comment:
How about the STALE, DECOMMISSIONING, DECOMMISSIONED to DEAD? Do nothing
or do something?
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
##########
@@ -265,7 +265,9 @@ private void initializeStateMachine() {
stateMachine.addTransition(
NodeState.DECOMMISSIONING, NodeState.DECOMMISSIONED,
NodeLifeCycleEvent.DECOMMISSIONED);
-
+ stateMachine.addTransition(
Review comment:
If we received unregister request, do you think it shouldn't change
state from XXX to DEAD only? Or we can remove the nodes at all? How about your
idea?
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -279,6 +281,24 @@ public RegisteredCommand register(
.build();
}
+ @Override
+ public UnRegisteredCommand unRegister(DatanodeDetails datanodeDetails) {
+ try {
+ nodeStateManager.removeNode(datanodeDetails);
Review comment:
Not sure we should remove the node from nodeStateManager, or only change
the state from STATEX to DEAD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
