[ 
https://issues.apache.org/jira/browse/HDDS-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Doroszlai resolved HDDS-3783.
------------------------------------
    Resolution: Invalid

Codecov will not compare against commits with failed CI (if it knows that CI 
passed or failed).  From the 
[doc|https://docs.codecov.io/docs/comparing-commits#commits-with-failed-ci]:

{quote}
If CI fails, one or more of the following assumptions can be made:
1. Not all tests were executed; therefore coverage is incomplete.
2. Exceptions may call new execution paths, resulting in different coverage 
metrics.
3. A failed test could produce different coverage than the same test ran 
successfully.
{quote}

> Upload coverage even if tests failed
> ------------------------------------
>
>                 Key: HDDS-3783
>                 URL: https://issues.apache.org/jira/browse/HDDS-3783
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.6.0
>            Reporter: Attila Doroszlai
>            Assignee: Attila Doroszlai
>            Priority: Major
>              Labels: pull-request-available
>
> PRs get code coverage feedback from Codecov thanks to changes implemented in 
> HDDS-3726.  Codecov needs coverage data for each new revision on master.  
> However, _coverage_ check is currently 
> [skipped|https://github.com/apache/hadoop-ozone/runs/759894317?check_suite_focus=true]
>  if any tests fail.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to