cxorm opened a new pull request #1075: URL: https://github.com/apache/hadoop-ozone/pull/1075
## What changes were proposed in this pull request? According the volume operations under [`hadoop-ozone/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume`](https://github.com/apache/hadoop-ozone/tree/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume) we could get **write** operations as follows: - Create Volume - Delete Volume - Update Volume - Set Quota - Set Owner - Acl Operations - Set Acl - Add Acl - Remove Acl #### Proposed fix. - Cleanup old write-path of volume in [`OzoneManger.java`](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java) - After cleaning old write-path of volume in `OzoneManager.java`, we could also clean up the write-operation in [`VolumeManager.java`](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/VolumeManager.java) - **note :** This part didn't clean the `createVolume()` because it is used by [`BenchMarkOMKeyAllocation.java`](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/genesis/BenchMarkOMKeyAllocation.java) - Remove test corresponding to the cleanup. - I think we could refactor the [`TestOmMetrics.java`](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmMetrics.java) to HA-version. (This PR just removed volume-related test.) - **Propose** creating jiras for fixing/updating `BenchMarkOMKeyAllocation.java` and `TestOmMetrics.java` ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-3369 ## How was this patch tested? [Github action passed](https://github.com/cxorm/hadoop-ozone/runs/771451070) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
