elek commented on a change in pull request #1074:
URL: https://github.com/apache/hadoop-ozone/pull/1074#discussion_r440156660



##########
File path: hadoop-ozone/dist/src/main/compose/ozone-mr/hadoop27/test.sh
##########
@@ -27,8 +27,8 @@ execute_robot_test scm createmrenv.robot
 
 
 #rm is the container name (resource manager) and not the rm command
-execute_command_in_container rm sudo -E apk add --update py-pip
-execute_command_in_container rm sudo -E pip install robotframework
+execute_command_in_container rm sudo -E yum install -y python3-pip

Review comment:
       This part can be removed. IMHO.
   
   ```
   docker run flokkr/hadoop:2.7.3 robot --version
   Flokkr launcher script 1.1-18-g58a3efc
   
   ===== Plugin is activated ENVTOCONF =====
   ======================================
   *** Launching "robot --version"
   Robot Framework 3.1.2 (Python 3.6.8 on linux)
   ```

##########
File path: hadoop-ozone/dist/src/main/compose/ozone-mr/hadoop27/docker-config
##########
@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-CORE-SITE.xml_fs.AbstractFileSystem.o3fs.impl=org.apache.hadoop.fs.ozone.OzFs

Review comment:
       What's wrong with `OzFS`? Based on my understanding `ozonefs-hadoop2` 
project includes an `OzFs` implementation which is the same as `BasicOzFs`.
   
   Is there any motivation behind this change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to