smengcl commented on a change in pull request #1087:
URL: https://github.com/apache/hadoop-ozone/pull/1087#discussion_r441818232



##########
File path: 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumes.java
##########
@@ -146,7 +146,6 @@ private void setVolumeAcl(ObjectStore objectStore, String 
volumeName,
   private void checkUser(MiniOzoneCluster cluster, UserGroupInformation user,
       List<String> expectVol, boolean expectListAllSuccess) throws IOException 
{
 
-    UserGroupInformation.setLoginUser(user);

Review comment:
       Just a note:
   
   Removing this line enables the existing tests to detect the bug solved by 
this jira.
   You see previously I set the login user to the user I'm calling listVolume 
with, which unintentionally hides the bug.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to