[
https://issues.apache.org/jira/browse/HDDS-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140098#comment-17140098
]
maobaolong commented on HDDS-3582:
----------------------------------
!screenshot-1.png!
!screenshot-2.png!
!screenshot-3.png!
!screenshot-4.png!
In fact, we have so many style problem now, i think we should correct these
problem, add more strict rule to avoid the bad style code.
I do think a famous project should have pretty code style, various style make
code mess and hard to maintain.
So, i propose to make a plan to correct these style debt after too late.
> Update Checkstyle rule
> ----------------------
>
> Key: HDDS-3582
> URL: https://issues.apache.org/jira/browse/HDDS-3582
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.6.0
> Reporter: maobaolong
> Assignee: maobaolong
> Priority: Major
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png
>
>
> Now. the rules of checkstyle is hadoop style, as we all know, hadoop repo
> started 10 years ago, so some of its rules need to be update.
> For example.
> - 120 length characters of a line make more sense, because most of all have a
> better monitor than 10 years ago.
> - We need more style rules, such as, behind and after "{" and "}" should have
> a space.
> - We should have manage the import into group and order them
> - ModifierOrder is needed
> - Remove the package javadoc rules.
> hope our community getting better and better
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
