elek commented on a change in pull request #1050:
URL: https://github.com/apache/hadoop-ozone/pull/1050#discussion_r442831540
##########
File path: hadoop-ozone/dist/src/main/compose/test-all.sh
##########
@@ -19,17 +19,22 @@
#
# Test executor to test all the compose/*/test.sh test scripts.
#
-
SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )
ALL_RESULT_DIR="$SCRIPT_DIR/result"
-
+PROJECT_DIR="$SCRIPT_DIR/.."
mkdir -p "$ALL_RESULT_DIR"
-rm "$ALL_RESULT_DIR/*"
+rm "$ALL_RESULT_DIR/*" || true
+
+if [ "$OZONE_WITH_COVERAGE" ]; then
+ java -cp "$PROJECT_DIR"/share/coverage/$(ls "$PROJECT_DIR"/share/coverage |
grep test-util):"$PROJECT_DIR"/share/coverage/jacoco-core.jar
org.apache.hadoop.test.JacocoServer &
+ DOCKER_BRIDGE_IP=$(docker network inspect bridge --format='{{(index
.IPAM.Config 0).Gateway}}')
Review comment:
> (I'm not sure because I have trouble starting any of the environments
with coverage enabled.)
How did you try? Docker bridge ip supposed to be available on all the
containers. But can be wrong on OSX. But worked well on github environments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
