xiaoyuyao commented on a change in pull request #814:
URL: https://github.com/apache/hadoop-ozone/pull/814#discussion_r443072850
##########
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##########
@@ -856,6 +864,10 @@ message DeletedKeys {
repeated string keys = 3;
}
+message DeleteKeysResponse {
Review comment:
Usually we have a XXXRequest match with XXXResponse. Here we have
DeleteKeysRequest->DeleteKeysResponse and UnDeletedKeysResponse.
NIT: can we keep this consistent to avoid confusion for UnDeleteKeysRequest
if any in the future?
```suggestion
message DeleteKeysResponse {
repeated KeyInfo deletedKeys = 1;
repeated KeyInfo unDeletedKeys = 2;
}```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
